Skip to content

Remove Service Override from aws.lambda spans #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 24, 2025
Merged

Remove Service Override from aws.lambda spans #666

merged 9 commits into from
Jul 24, 2025

Conversation

@zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Jul 12, 2025 •
edited
Loading

What does this PR do?

Change the lambda span service name priority:

  1. value of DD_SERVICE
  2. value of lambda function name
  3. aws.lambda

Also changes cold_start values to true/false

Adds DD_TRACE_AWS_SERVICE_REPRESENTATION_ENABLED to allow disabling of feature when set to false. Default is true.

Motivation

Removes service overrides for aws.lambda span

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@zarirhamza zarirhamza requested review from a team as code owners July 12, 2025 02:17
astuyve
astuyve requested changes Jul 12, 2025
View reviewed changes
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this can ship. Many assumptions are made in the backend based on this

@zarirhamza
Copy link
Contributor Author

zarirhamza commented Jul 12, 2025 •
edited
Loading

I don't think this can ship. Many assumptions are made in the backend based on this

What part exactly is blocking? Is it changing the service name from aws.lambda to functionName? That change was already merged in #655. The only thing to look out for was span.name according to Rey and that is different from serviceName. The property span.name is akin to operation name which is unchanged with these changes.

Or is it respecting the DD_SERVICE env var specifically for lambda spans? That isn't really changing any behavior because the rust extension already does that. This change simply performs that renaming earlier in the life of the trace so that base_service is not on the tracer leading to indications of a service override on the UI even though the base_service and actual service are the same.

@zarirhamza
Copy link
Contributor Author

zarirhamza commented Jul 15, 2025

Reminder - Use this PR to collapse cold start to use Boolean values

joeyzhao2018
joeyzhao2018 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarirhamza zarirhamza merged commit c3b9e60 into main Jul 24, 2025
26 checks passed
@zarirhamza zarirhamza deleted the zarir/fix_service_override branch July 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astuyve astuyve astuyve approved these changes

@joeyzhao2018 joeyzhao2018 joeyzhao2018 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zarirhamza @astuyve @joeyzhao2018